Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: lazy load workbox-build to reduce config loading time #244

Merged
merged 1 commit into from Apr 18, 2022

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Mar 11, 2022

I was thinking that vite's starting up time was slow in my project.
I digged down a bit and found that evaluating workbox-build was making it slow.

This PR changes workbox-build to be lazy loaded.
Since workbox-build is not always used, I think it is ok to do this.

Without this PR, my project takes about 1300 - 1500ms to start up.
With this PR, it takes about 500 - 600ms.

These values are obtained from output with DEBUG="vite:config" npm run dev like bundled config file loaded in 565.03ms +0ms.

@netlify
Copy link

netlify bot commented Mar 11, 2022

✔️ Deploy Preview for vite-plugin-pwa ready!

🔨 Explore the source changes: 68ac570

🔍 Inspect the deploy log: https://app.netlify.com/sites/vite-plugin-pwa/deploys/622b0abc665fa600097745fd

😎 Browse the preview: https://deploy-preview-244--vite-plugin-pwa.netlify.app

@userquin
Copy link
Member

userquin commented Apr 3, 2022

@sapphi-red

sorry for the delay, testing with vitesse template also the dev startup from 2s to 1.2s, loading workbox-build on demand:

  vite v2.9.0 dev server running at:

  > Local: http://localhost:3333/
  > Network: use `--host` to expose

  ready in 1201ms.

with static import:

  vite v2.9.0 dev server running at:

  > Local: http://localhost:3333/
  > Network: use `--host` to expose

  ready in 2069ms.

@userquin userquin merged commit 1873302 into vite-pwa:main Apr 18, 2022
@sapphi-red sapphi-red deleted the perf/lazy-load-workbox-build branch April 19, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants